Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15673#discussion_r85633937
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
    @@ -585,7 +585,18 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
             getAllPartitionsMethod.invoke(hive, 
table).asInstanceOf[JSet[Partition]]
           } else {
             logDebug(s"Hive metastore filter is '$filter'.")
    -        getPartitionsByFilterMethod.invoke(hive, table, 
filter).asInstanceOf[JArrayList[Partition]]
    +        try {
    +          // Hive may throw an exception when calling this method in some 
circumstances, such as
    +          // when filtering on a non-string partition column when the hive 
config key
    +          // hive.metastore.try.direct.sql is false
    +          getPartitionsByFilterMethod.invoke(hive, table, filter)
    +            .asInstanceOf[JArrayList[Partition]]
    +        } catch {
    +          case ex: InvocationTargetException if 
ex.getCause.isInstanceOf[MetaException] =>
    +            logWarning("Caught MetaException attempting to get partitions 
by filter from Hive", ex)
    --- End diff --
    
    change the msg to say we are falling back to fetch all partitions' 
medatadata?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to