Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15659#discussion_r85634800
--- Diff: dev/create-release/release-build.sh ---
@@ -162,14 +162,35 @@ if [[ "$1" == "package" ]]; then
export ZINC_PORT=$ZINC_PORT
echo "Creating distribution: $NAME ($FLAGS)"
+ # Write out the NAME and VERSION to PySpark version info we rewrite
the - into a . and SNAPSHOT
+ # to dev0 to be closer to PEP440. We use the NAME as a "local version".
+ PYSPARK_VERSION=`echo "$SPARK_VERSION+$NAME" | sed -r "s/-/./" | sed
-r "s/SNAPSHOT/dev0/"`
+ echo "__version__='$PYSPARK_VERSION'" > python/pyspark/version.py
--- End diff --
We need it if the user runs setup.py sdist on their on own and as part of
the packaging tests during any Python change in Jenkins. If the only way to
build a pip installable package was make_release then yes - but that isn't the
case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
