Github user sethah commented on the issue:
https://github.com/apache/spark/pull/14937
@yanboliang I began to run some performance tests on this patch today. With
this patch the way it is, I am seeing a huge performance **_degradation_**. The
most critical reason is the slicing (copying) of the centers array inside the
inner, inner while loop. The reason I ask is because I don't see how the
results posted in this PR could even occur against the current patch. Were
those from an older version? I know this PR has gone through several iterations
and so I'm just trying to get a sense for where those results came from.
It would be great if we could resolve the merge conflicts and start moving
review along. I'm happy to help :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
