Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15672#discussion_r85787971
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
    @@ -15,3 +15,26 @@ select 'foo', approx_count_distinct(int_col) from myview 
where int_col == 0 grou
     
     -- group-by should not produce any rows (sort aggregate).
     select 'foo', max(struct(int_col)) from myview where int_col == 0 group by 
1;
    +
    +-- Test data.
    +CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES
    +(1, 1), (1, 2), (2, 1), (2, 2), (3, 1), (3, 2), (null, 1), (3, null), 
(null, null)
    +AS testData(a, b);
    --- End diff --
    
    Also can we just augment the initial dataset rather than introducing a new 
testData?
    
    It'd be better to use one dataset.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to