Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15628#discussion_r85799898
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -153,6 +153,86 @@ sealed trait Matrix extends Serializable {
*/
@Since("2.0.0")
def numActives: Int
+
+ /**
+ * Converts this matrix to a sparse matrix.
+ *
+ * @param columnMajor Whether the values of the resulting sparse matrix
should be in column major
+ * or row major order. If `false`, resulting matrix
will be row major.
+ */
+ private[ml] def toSparseMatrix(columnMajor: Boolean): SparseMatrix
--- End diff --
A bit of explanation: I made this a private method with a different name
because `toDense: DenseMatrix` and `toSparse: SparseMatrix` should be
implemented in the trait, not in the subclasses. But we can't just put them
here and use overloading, because we will get ambiguous reference compile
errors. So, we implement them here and make this private with a different name
to avoid this. I appreciate feedback on this approach - it feels a bit awkward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
