Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85833766
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
* Adds a JAR dependency for all tasks to be executed on this
SparkContext in the future.
* The `path` passed can be either a local file, a file in HDFS (or
other Hadoop-supported
* filesystems), an HTTP, HTTPS or FTP URI, or local:/path for a file on
every worker node.
+ * If addToCurrentClassLoader is true, attempt to add the new class to
the current threads' class
+ * loader. In general adding to the current threads' class loader will
impact all other
+ * application threads unless they have explicitly changed their class
loader.
*/
def addJar(path: String) {
+ addJar(path, false)
+ }
+
+ def addJar(path: String, addToCurrentClassLoader: Boolean) {
--- End diff --
Keeping it in the Scala makes it simpler for other spark Scala interpeters
(eg toree, zeppelin) to make use of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
