Github user lins05 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15541#discussion_r85956857
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -305,12 +307,8 @@ private[spark] class TaskSchedulerImpl(
             hostsByRack.getOrElseUpdate(rack, new HashSet[String]()) += o.host
           }
         }
    +    taskAssigner.construct(offers)
    --- End diff --
    
    The comments of the `resourceOffers` method shoud be updated. It still says 
`We fill each node with tasks in a round-robin manner so that tasks are 
balanced across the cluster.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to