Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15675#discussion_r86030545
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingQueryListenerBus.scala
 ---
    @@ -50,7 +52,14 @@ class StreamingQueryListenerBus(sparkListenerBus: 
LiveListenerBus)
       override def onOtherEvent(event: SparkListenerEvent): Unit = {
         event match {
           case e: StreamingQueryListener.Event =>
    -        postToAll(e)
    +        // SPARK-18144: we broadcast QueryStartedEvent to all listeners 
attached to this bus
    +        // synchronously and to listeners attached to LiveListenerBus 
asynchronously. Therefore,
    +        // we need to ignore QueryStartedEvent if this method is called 
within SparkListenerBus
    +        // thread
    +        if (Thread.currentThread().getName != "SparkListenerBus" ||
    --- End diff --
    
    nit: please use `!LiveListenerBus.withinListenerThread.value` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to