Github user ericl commented on the issue:
https://github.com/apache/spark/pull/15705
I think you don't have to since this is just the test suite.
On Tue, Nov 1, 2016, 8:49 PM Wenchen Fan <[email protected]> wrote:
> *@cloud-fan* commented on this pull request.
> ------------------------------
>
> In
>
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
> <https://github.com/apache/spark/pull/15705#pullrequestreview-6745958>:
>
> > @@ -180,7 +180,16 @@ class PlanParserSuite extends PlanTest {
> partition: Map[String, Option[String]],
> overwrite: Boolean = false,
> ifNotExists: Boolean = false): LogicalPlan =
> - InsertIntoTable(table("s"), partition, plan, overwrite,
ifNotExists)
> + InsertIntoTable(
> + table("s"), partition, plan,
> + OverwriteOptions(
> + overwrite,
> + if (overwrite && partition.nonEmpty) {
> + Some(partition.map(kv => (kv._1, kv._2.get)))
>
> do we need to consider dynamic partition here?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/15705#pullrequestreview-6745958>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAA6SpEB-R5k4u55HP0Wt6z9i1OihpNSks5q6AhJgaJpZM4KlpEq>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
