Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15011#discussion_r86080437
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
 ---
    @@ -127,6 +127,18 @@ class SessionCatalogSuite extends SparkFunSuite {
         catalog.dropDatabase("db_that_does_not_exist", ignoreIfNotExists = 
true, cascade = false)
       }
     
    +  test("drop current database and drop default database") {
    +    val catalog = new SessionCatalog(newBasicCatalog())
    +    catalog.setCurrentDatabase("db1")
    +    assert(catalog.getCurrentDatabase == "db1")
    +    catalog.dropDatabase("db1", ignoreIfNotExists = false, cascade = true)
    --- End diff --
    
    After you drop the database, could you also add some statements that try to 
use the dropped one? We should expect some error messages here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to