Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86216703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,36 @@ package org.apache.spark.sql.execution.streaming
* ordering of two [[Offset]] instances. We do assume that if two offsets
are `equal` then no
* new data has arrived.
*/
-trait Offset extends Serializable {}
+abstract class Offset {
+
+ /**
+ * Equality based on JSON string representation.
+ */
+ override final def equals(obj: Any): Boolean = obj match {
+ case o: Offset => this.json == o.json
+ case _ => false
+ }
+
+ override def hashCode(): Int = this.json.hashCode
--- End diff --
need to add `final`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
