Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2169#discussion_r16916722
  
    --- Diff: 
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocationHandler.scala
 ---
    @@ -521,48 +203,24 @@ private[yarn] class YarnAllocationHandler(
         rsrcRequest
       }
     
    -  def createReleasedContainerList(): ArrayBuffer[ContainerId] = {
    -
    +  private def createReleasedContainerList(): ArrayBuffer[ContainerId] = {
         val retval = new ArrayBuffer[ContainerId](1)
         // Iterator on COW list ...
    -    for (container <- releasedContainerList.iterator()){
    +    for (container <- releaseList.iterator()){
           retval += container
         }
         // Remove from the original list.
    -    if (! retval.isEmpty) {
    -      releasedContainerList.removeAll(retval)
    -      for (v <- retval) pendingReleaseContainers.put(v, true)
    -      logInfo("Releasing " + retval.size + " containers. 
pendingReleaseContainers : " +
    -        pendingReleaseContainers)
    +    if (!retval.isEmpty) {
    +      releaseList.removeAll(retval)
    +      logInfo("Releasing " + retval.size + " containers.")
         }
    -
         retval
       }
     
    -  // A simple method to copy the split info map.
    -  private def generateNodeToWeight(
    -    conf: Configuration,
    -    input: collection.Map[String, collection.Set[SplitInfo]]) :
    -  // host to count, rack to count
    -  (Map[String, Int], Map[String, Int]) = {
    -
    -    if (input == null) return (Map[String, Int](), Map[String, Int]())
    -
    -    val hostToCount = new HashMap[String, Int]
    -    val rackToCount = new HashMap[String, Int]
    -
    -    for ((host, splits) <- input) {
    -      val hostCount = hostToCount.getOrElse(host, 0)
    -      hostToCount.put(host, hostCount + splits.size)
    -
    -      val rack = YarnSparkHadoopUtil.lookupRack(conf, host)
    -      if (rack != null){
    -        val rackCount = rackToCount.getOrElse(host, 0)
    -        rackToCount.put(host, rackCount + splits.size)
    -      }
    -    }
    -
    -    (hostToCount.toMap, rackToCount.toMap)
    +  class AlphaAllocateResponse(response: AMResponse) extends 
YarnAllocateResponse {
    --- End diff --
    
    I don't think anyone outside of this will need this should we make this and 
the Stable on private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to