Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86384641 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -383,16 +506,7 @@ class DoubleAccumulator extends AccumulatorV2[jl.Double, jl.Double] { * Adds v to the accumulator, i.e. increment sum by v and count by 1. * @since 2.0.0 */ - override def add(v: jl.Double): Unit = { - _sum += v - _count += 1 - } - - /** - * Adds v to the accumulator, i.e. increment sum by v and count by 1. - * @since 2.0.0 - */ - def add(v: Double): Unit = { --- End diff -- see comment on `@specialized`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org