Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15756#discussion_r86422590
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -540,7 +544,8 @@ private[spark] object JsonProtocol {
     
       def taskStartFromJson(json: JValue): SparkListenerTaskStart = {
         val stageId = (json \ "Stage ID").extract[Int]
    -    val stageAttemptId = (json \ "Stage Attempt 
ID").extractOpt[Int].getOrElse(0)
    +    val stageAttemptId =
    +      Utils.jsonOption(json \ "Stage Attempt 
ID").map(_.extract[Int]).getOrElse(0)
    --- End diff --
    
    if so maybe we should add a scalastyle to ban it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to