Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15743#discussion_r86435578
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
    @@ -54,7 +52,7 @@ class TaskInfo(
        * accumulable to be updated multiple times in a single task or for two 
accumulables with the
        * same name but different IDs to exist in a task.
        */
    -  val accumulables = ListBuffer[AccumulableInfo]()
    --- End diff --
    
    In order to maintain binary compatibility, I could rewrite this to be a 
`lazy val` that returns a `ListBuffer` formed from the "real" `accumulables` 
which can remain private. I might go ahead and do that just to avoid any chance 
of incompatibility-related problems, although I don't anticipate this being an 
issue in practice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to