Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/15737
Two comments:
- I think `sc.conf.getTimeAsSeconds("spark.network.timeout",
"120s").toString` is still wrong. The suggestion is to make it the following:
```scala
val pollTimeoutMs = sourceOptions.getOrElse(
"kafkaConsumer.pollTimeoutMs",
sc.conf.getTimeAsMs("spark.network.timeout", "120s").toString).toLong
```
or maybe
```scala
val pollTimeoutMs = sourceOptions
.get("kafkaConsumer.pollTimeoutMs")
.map(_.toLong)
.getOrElse(sc.conf.getTimeAsMs("spark.network.timeout", "120s"))
```
- I'm not sure about the test changes. Unless there is a good reason, I'd
leave the tests alone and just use the default configuration there as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
