Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11105#discussion_r86493318
--- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
@@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends
Serializable {
def reset(): Unit
/**
+ * Takes the inputs and accumulates. e.g. it can be a simple `+=` for
counter accumulator.
+ * Developers should extend addImpl to customize the adding
functionality.
+ */
+ final def add(v: IN): Unit = {
--- End diff --
drat :( Do we want to do AccumulatorV3 and deprecate AccumulatorV2's
constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
