Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86493730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -131,6 +131,26 @@ case class CreateViewCommand(
s"specified by CREATE VIEW (num:
`${userSpecifiedColumns.length}`).")
}
+ // When creating a permanent view, not allowed to reference temporary
objects.
+ if (!isTemporary) {
+ child.collect {
+ // Disallow creating permanent views based on temporary views.
+ case s: UnresolvedRelation
+ if
sparkSession.sessionState.catalog.isTemporaryTable(s.tableIdentifier) =>
+ throw new AnalysisException(s"Not allowed to create a permanent
view $name by " +
+ s"referencing a temp view ${s.tableIdentifier}. " +
+ originalText.map(sql => s"""SQL: "$sql".""").getOrElse(""))
+ case other if !other.resolved =>
other.expressions.flatMap(_.collect {
+ // Disallow creating permanent views based on temporary UDFs.
+ case e: UnresolvedFunction
+ if
sparkSession.sessionState.catalog.isTemporaryFunction(e.name) =>
+ throw new AnalysisException(s"Not allowed to create a
permanent view $name by " +
+ s"referencing a temp function `${e.name}`. " +
+ originalText.map(sql => s"""SQL: "$sql".""").getOrElse(""))
--- End diff --
same here do we really need to show the entire sql? it's basically what the
user just typed in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
