Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15771#discussion_r86610683
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ---
    @@ -499,6 +499,7 @@ case class JsonToStruct(schema: StructType, options: 
Map[String, String], child:
     
       override def eval(input: InternalRow): Any = {
         try parser.parse(child.eval(input).toString).head catch {
    +      case _: NullPointerException => null
    --- End diff --
    
    I would consider doing this with an `if`.  I think catching and throwing an 
exception can be expensive (though maybe JVM optimizations save us?).  Since 
its easy I'd rather not rely on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to