Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15286#discussion_r86613864
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2489,8 +2489,10 @@ private[spark] class CallerContext(
def setCurrentContext(): Boolean = {
var succeed = false
try {
- val callerContext =
Utils.classForName("org.apache.hadoop.ipc.CallerContext")
- val Builder =
Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
+ // scalastyle:off classforname
--- End diff --
I think it's important to document why we are not using Utils.classForName
here. Otherwise somebody is going to come in the future and get confused or
change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
