GitHub user sethah opened a pull request:

    https://github.com/apache/spark/pull/15773

    [SPARK-18276][ML] ML models should copy the training summary and set parent

    ## What changes were proposed in this pull request?
    
    Only some of the models which contain a training summary currently set the 
summaries in the copy method. Linear/Logistic regression do, GLR, GMM, KM, and 
BKM do not. Additionally, these copy methods did not set the parent pointer of 
the copied model. This patch modifies the copy methods of the four models 
mentioned above to copy the training summary and set the parent.
    
    ## How was this patch tested?
    
    Add unit tests in Linear/Logistic/GeneralizedLinear regression and 
GaussianMixture/KMeans/BisectingKMeans to check the parent pointer of the 
copied model and check that the copied model has a summary.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sethah/spark SPARK-18276

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15773
    
----
commit 9d2a64be0676718259fedd8d9090717fb2432457
Author: sethah <[email protected]>
Date:   2016-11-04T20:40:58Z

    add tests for copy summary

commit 6bb2871be0d866252ec90a802a6e3043a503990a
Author: sethah <[email protected]>
Date:   2016-11-04T20:53:32Z

    cleanups

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to