Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86637627
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -187,16 +193,32 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
if (tableExists(db, table) && !ignoreIfExists) {
throw new TableAlreadyExistsException(db = db, table = table)
}
- // Before saving data source table metadata into Hive metastore, we
should:
- // 1. Put table metadata like provider, schema, etc. in table
properties.
- // 2. Check if this table is hive compatible
- // 2.1 If it's not hive compatible, set location URI, schema,
partition columns and bucket
- // spec to empty and save table metadata to Hive.
- // 2.2 If it's hive compatible, set serde information in table
metadata and try to save
- // it to Hive. If it fails, treat it as not hive compatible
and go back to 2.1
- if (DDLUtils.isDatasourceTable(tableDefinition)) {
+
+ if (tableDefinition.tableType == VIEW) {
+ client.createTable(tableDefinition, ignoreIfExists)
+ } else if (tableDefinition.provider.get == "hive") {
--- End diff --
Can we compare against a constant instead of a string literal here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
