Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15771#discussion_r86643260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -498,7 +498,7 @@ case class JsonToStruct(schema: StructType, options:
Map[String, String], child:
override def children: Seq[Expression] = child :: Nil
override def eval(input: InternalRow): Any = {
- try parser.parse(child.eval(input).toString).head catch {
+ try Option(child.eval(input)).map(json =>
parser.parse(json.toString).head).orNull catch {
--- End diff --
Sorry to keep iterating... I think you want to avoid an extra allocation in
the execution path. I would use an `if` statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
