Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r86603980
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -84,7 +85,7 @@ private[spark] class TaskSetManager(
var totalResultSize = 0L
var calculatedTasks = 0
- private val taskSetBlacklistHelperOpt: Option[TaskSetBlacklist] = {
+ private[scheduler] val taskSetBlacklistHelperOpt:
Option[TaskSetBlacklist] = {
--- End diff --
do you think we should check in this method that taskSetBlacklistHelperOpt
and blacklistTracker are either both set or neither set? I'm wondering if we
should check that invariant -- since maybeFinishTaskSet relies on the
assumption that if one is set, the other is set as well. Alternately, you
could initialize taskSetBlacklistHelperOpt based on whether blacklistTracker is
set, rather than checking isBlacklistEnabled
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
