GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2214
[SQL] Refined Thrift server test suite
This PR fixes two issues of `HiveThriftServer2Suite` and brings 1
enhancement:
1. Although metastore, warehouse directories and listening port are
randomly chosen, all test cases share the same configuration. Due to parallel
test execution, one of the two test case is doomed to fail
2. We caught any exceptions thrown from a test case and print diagnosis
information, but forgot to re-throw the exception...
3. When the forked server process ends prematurely (e.g., fails to start),
the `serverRunning` promise is completed with a failure, preventing the test
code to keep waiting until timeout.
So, embarrassingly, this test suite was failing continuously for several
days but no one had ever noticed it... Fortunately no bugs in the production
were covered under the hood.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liancheng/spark refine-thrift-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2214
----
commit 983d030b7fbdfb1a11faedfc83a32accf9573134
Author: Cheng Lian <[email protected]>
Date: 2014-08-30T04:45:50Z
Refined Thrift server test suite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
