Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15764#discussion_r86691637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -923,6 +923,24 @@ class SessionCatalog(
}
}
+ /**
+ * Returns whether it is a temporary function. If not existed, returns
false.
+ */
+ def isTemporaryFunction(name: FunctionIdentifier): Boolean = {
+ // copied from HiveSessionCatalog
+ val hiveFunctions = Seq(
+ "hash",
+ "histogram_numeric",
+ "percentile")
+
+ // A temporary function is a function that has been registered in
functionRegistry
+ // without a database name, and is neither a built-in function nor a
Hive function
+ name.database.isEmpty &&
+ functionRegistry.functionExists(name.funcName) &&
+ !FunctionRegistry.builtin.functionExists(name.funcName) &&
+ !hiveFunctions.contains(name.funcName.toLowerCase)
--- End diff --
I thought `HiveSessionCatalog` is used in context of Hive and
`SessionCatalog` has nothing to do with Hive. So if we remove this from here
and override `isTemporaryFunction` in `HiveSessionCatalog`, this would look
clean. Feels like I am missing something obvious here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
