Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15786#discussion_r86901995
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala
---
@@ -212,4 +212,8 @@ class MemorySink(val schema: StructType, outputMode:
OutputMode) extends Sink wi
*/
case class MemoryPlan(sink: MemorySink, output: Seq[Attribute]) extends
LeafNode {
def this(sink: MemorySink) = this(sink, sink.schema.toAttributes)
+
+ private val sizePerRow =
sink.schema.toAttributes.map(_.dataType.defaultSize).sum
+
+ override def statistics: Statistics = Statistics(sizePerRow *
sink.allData.size)
--- End diff --
thanks @brkyvz. I'm afraid it should not be `lazy val` as the statistics
should vary from batch to batch -- `sink.allData.size`should vary from batch to
batch. `sizePerRow`, however, does not vary from batch to batch, thus it's
`private val` as it is now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
