GitHub user brkyvz opened a pull request:

    https://github.com/apache/spark/pull/15804

    [SPARK-18342] Make rename failures fatal in HDFSBackedStateStore

    ## What changes were proposed in this pull request?
    
    If the rename operation in the state store fails (`fs.rename` returns 
`false`), the StateStore should throw an exception and have the task retry. 
Currently if renames fail, nothing happens during execution immediately. 
However, you will observe that snapshot operations will fail, and then any 
attempt at recovery (executor failure / checkpoint recovery) also fails.
    
    ## How was this patch tested?
    
    Unit test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brkyvz/spark rename-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15804
    
----
commit 4c2d1fd2766750b94a15fa8febd110f27c9f2514
Author: Burak Yavuz <[email protected]>
Date:   2016-11-08T03:45:23Z

    fix rename

commit e0c164b86ce7cff0750615c16b2ee41905bfb875
Author: Burak Yavuz <[email protected]>
Date:   2016-11-08T04:42:26Z

    added test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


Reply via email to