Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15814#discussion_r87111758
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
 ---
    @@ -42,17 +44,21 @@ class HadoopMapReduceCommitProtocol(jobId: String, 
path: String)
       /** OutputCommitter from Hadoop is not serializable so marking it 
transient. */
       @transient private var committer: OutputCommitter = _
     
    +  /**
    +   * Tracks files staged by this task for absolute output paths. These 
outputs are not managed by
    +   * the Hadoop OutputCommitter, so we must move these to their final 
locations on job commit.
    +   */
    +  @transient private var addedAbsPathFiles: mutable.Map[String, String] = 
null
    --- End diff --
    
    They are files. We need to track the unique output location of each file 
here in order to know where to place it. We could use directories, but they 
would end up with one file each anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to