Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87174202
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -32,13 +32,7 @@ import org.apache.spark.sql.types.StructType
* :: Experimental ::
*
* Model produced by [[MinHash]], where multiple hash functions are
stored. Each hash function is
- * a perfect hash function:
- * `h_i(x) = (x * k_i mod prime) mod numEntries`
- * where `k_i` is the i-th coefficient, and both `x` and `k_i` are from
`Z_prime^*`
- *
- * Reference:
- * [[https://en.wikipedia.org/wiki/Perfect_hash_function Wikipedia on
Perfect Hash Function]]
- *
+ * a perfect hash.
--- End diff --
@jkbradley is it not more confusing to not have any reference or further
explanation here? You mentioned in
https://github.com/apache/spark/pull/15148#issuecomment-258991190 to remove
this, but should we not have some doc here or a better reference instead of
nothing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
