Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15652#discussion_r87231743
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -307,15 +307,26 @@ private[spark] object JettyUtils extends Logging {
connectors += httpConnector
sslOptions.createJettySslContextFactory().foreach { factory =>
- // If the new port wraps around, do not try a privileged port.
+
+ require(sslOptions.port == 0 || (1024 <= sslOptions.port &&
sslOptions.port < 65536),
+ "securePort should be between 1024 and 65535 (inclusive)," +
+ " or 0 for determined automatically.")
+
val securePort =
if (currentPort != 0) {
- (currentPort + 400 - 1024) % (65536 - 1024) + 1024
+ // If the new port wraps around, do not try a privileged port.
+ if (1024 <= sslOptions.port && sslOptions.port < 65536) {
--- End diff --
To me it seems easier to flip the if condition, and just check for the port
being 0, rather than repeat this condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
