Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87467314
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -103,67 +46,27 @@ public synchronized void kill() {
try {
childProc.exitValue();
} catch (IllegalThreadStateException e) {
- // Child is still alive. Try to use Java 8's "destroyForcibly()"
if available,
- // fall back to the old API if it's not there.
try {
- Method destroy =
childProc.getClass().getMethod("destroyForcibly");
- destroy.invoke(childProc);
- } catch (Exception inner) {
childProc.destroy();
+ } catch (Exception inner) {
--- End diff --
This will never happen. You're breaking the existing functionality. See my
previous comment (https://github.com/apache/spark/pull/15009/files#r84788125).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
