Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15851#discussion_r87693230
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala ---
    @@ -41,5 +41,29 @@ object RWrapperUtils extends Logging {
             s"using new name $newFeaturesName instead")
           rFormula.setFeaturesCol(newFeaturesName)
         }
    +
    +    if (rFormula.getForceIndexLabel && 
data.schema.fieldNames.contains(rFormula.getLabelCol)) {
    +      val newLabelName = s"${Identifiable.randomUID(rFormula.getLabelCol)}"
    +      logWarning(s"data containing ${rFormula.getLabelCol} column and we 
force to index label, " +
    +        s"using new name $newLabelName instead")
    +      rFormula.setLabelCol(newLabelName)
    +    }
    +  }
    +
    +  /**
    +   * Get the feature names and original labels from the schema
    +   * of DataFrame transformed by RFormulaModel.
    --- End diff --
    
    It could have but not must, since it should be private. BTW, I found we 
should make object ```RWrapperUtils``` private[r], and will fix it soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to