GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/15867
[WIP][SPARK-18423][Streaming] ReceiverTracker should close checkpoint dir
when stopped even if it was not started
## What changes were proposed in this pull request?
Several tests are being failed on Windows due to the failure of removing
the checkpoint dir between each tests.
This is caused by not closed file in `ReceiverTracker`. When it is not
started, it does not close it even if `stop()` is called.
```
Tests run: 53, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 22.325 sec
<<< FAILURE! - in org.apache.spark.streaming.JavaAPISuite
testCheckpointMasterRecovery(org.apache.spark.streaming.JavaAPISuite) Time
elapsed: 3.418 sec <<< ERROR!
java.io.IOException: Failed to delete:
C:\projects\spark\streaming\target\tmp\1474255953021-0
at
org.apache.spark.streaming.JavaAPISuite.testCheckpointMasterRecovery(JavaAPISuite.java:1808)
Running org.apache.spark.streaming.JavaDurationSuite
```
```
mapWithState - basic operations with simple API (7 seconds, 203
milliseconds)
[info] Exception encountered when attempting to run a suite with class
name: org.apache.spark.streaming.MapWithStateSuite *** ABORTED *** (12 seconds,
469 milliseconds)
[info] java.io.IOException: Failed to delete:
C:\projects\spark\streaming\checkpoint\spark-226c0e37-8c46-4b2a-9c0f-2317cde31d40
```
## How was this patch tested?
Tests in `JavaAPISuite` and `MapWithStateSuite`.
Manually tested via AppVeyor:
**Before**
- `org.apache.spark.streaming.JavaAPISuite`
Build:
https://ci.appveyor.com/project/spark-test/spark/build/71-MapWithStateSuite-1
Diff:
https://github.com/apache/spark/compare/master...spark-test:188c828e682ec45b75d15c3dfc782bcdc8ce024c
- `org.apache.spark.streaming.MapWithStateSuite`
Build:
https://ci.appveyor.com/project/spark-test/spark/build/72-MapWithStateSuite-1
Diff:
https://github.com/apache/spark/compare/master...spark-test:8f6945d0ccde022a23d3848f6b7fe6da1e7c902e
**After**
...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-18423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15867.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15867
----
commit 76f2718199f64aad5101965790931d3ee2967a7d
Author: hyukjinkwon <[email protected]>
Date: 2016-11-12T20:16:10Z
Fix ReceiverTracker
commit 8b05ba7cc88d7d5115b97ebb14a0786099c5fe9f
Author: hyukjinkwon <[email protected]>
Date: 2016-11-12T20:17:01Z
Fix comment better
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
