Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15860
Looks good to me. I did a bit of digging and it looks like the bug that
this fixes actually ended up causing silent failures in our nightly snapshot
package builder:
-
http://people.apache.org/~pwendell/spark-nightly/spark-branch-2.0-bin/spark-2.0.3-SNAPSHOT-2016_11_08_00_23-a39f8c1-bin/,
which is built off of branch-2.0, has all of the expected packages
-
http://people.apache.org/~pwendell/spark-nightly/spark-master-bin/spark-2.1.0-SNAPSHOT-2016_11_09_01_03-e256392-bin/
is missing the packages whose Maven profiles were invalid.
In the builder, the invalid profiles showed up as warnings in the logs:
```
+ VERSION='[WARNING] The requested profile "hadoop2.6" could not be
activated because it does not exist.'
```
While in the longer term it might be nice to strengthen error-checks in
that script to make sure that this doesn't silently break, I don't think it's
necessary to do now or a super high priority in general (since any bug here
will be caught prior to release), so this looks good to me and I'll merge it
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
