Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15659
I just tested this out end-to-end on my Mac and it worked great. I have
only one minor concern that I'd like to fix regarding the `version.py` file:
Today, the `./dev/create-release/release-tag.sh` script has special logic
for updating the `R` package version files by editing them in-place using
`sed`; I think it would make sense to move the `sed` logic that you currently
have in `release-build.sh` into here so that all rewriting of files takes place
outside of the actual build process itself when creating release (in other
words, we'll be running `release-build.sh` on a git tag whose files already
have the right versions edited in rather than doing it at compile-time). I
think this is important in order to have all of the versions be consistent in
the git tag itself, otherwise I think we'll hit problems when folks are
reviewing the release artifacts.
Therefore, I think we should move those `sed` lines right below
https://github.com/apache/spark/blob/1386fd28daf798bf152606f4da30a36223d75d18/dev/create-release/release-tag.sh#L77
In addition, it might be nice to do a `from pyspark.version import
__version__` in `python/pyspark/__init__.py` so that end users can then write
`import pyspark; pyspark.__version__`, which is a nice idiom that works for
many other Python packages.
Besides this one piece of feedback, I think the rest looks good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
