Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13837#discussion_r87733959
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -322,6 +323,9 @@ case class DataSource(
               val equality = sparkSession.sessionState.conf.resolver
               StructType(schema.filterNot(f => 
partitionColumns.exists(equality(_, f.name))))
             }.orElse {
    +          if (allPaths.isEmpty && !format.isInstanceOf[TextFileFormat]) {
    --- End diff --
    
    Hi @gatorsmile, would this be better if we explain here text data source is 
excluded because text datasource always uses a schema consisting of a string 
field if the schema is not explicitly given?
    
    BTW, should we maybe change `text.TextFileFormat` to `TextFileFormat ` 
https://github.com/apache/spark/pull/13837/files#diff-7a6cb188d2ae31eb3347b5629a679cecR139
 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to