Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15857#discussion_r87743162
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -449,7 +452,7 @@ object FoldablePropagation extends Rule[LogicalPlan] {
               stop = true
               j
     
    -        // These 3 operators take attributes as constructor parameters, 
and these attributes
    +        // These 4 operators take attributes as constructor parameters, 
and these attributes
    --- End diff --
    
    shall we turn to whitelist? As I remember there have been more than 3 bugs 
reported on this optimizer rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to