Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15763#discussion_r87814868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1069,11 +1110,19 @@ class Analyzer(
case a @ Aggregate(grouping, expressions, child) =>
failOnOuterReference(a)
val referencesToAdd = missingReferences(a)
+ if (foundNonEqualCorrelatedPred) {
+ failOnNonEqualCorrelatedPredicate(a)
+ }
if (referencesToAdd.nonEmpty) {
Aggregate(grouping ++ referencesToAdd, expressions ++
referencesToAdd, child)
} else {
a
}
+ case w : Window =>
+ if (foundNonEqualCorrelatedPred) {
+ failOnNonEqualCorrelatedPredicate(w)
+ }
+ w
--- End diff --
Should we rewrite the aggregates in the window function? For example:
```sql
select *
from tbl_x
where value in (select max() over() from tbl_y where tbl_y.id = tbl_x.id)
```
Should we rewrite `max() over()` into `max() over(partition by tbl_y.id)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
