Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/15876
LGTM. Thanks. Merged into master and 2.1 branch.
@srowen Are you referring the MLOR PR which has many followup PRs? If so,
the changes in the main MLOR PR is very big, and many of the issues can be
broke into smaller tasks. To avoid dealing with many conflicts, we decided to
work on those smaller tasks which had been identified in the reviewing process
in the early development of 2.1 so we can move faster (some of them may require
extra infrastructure outside the algorithm so we don't want to do it together).
Do you think we could have a guideline or checklist so the reviewers can
consistently check how to do error handling (there are different type of
exception being thrown for similar error) or coding style in addition to
correctness of the algorithms? Any suggestion? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
