Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r87874663
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
@@ -35,26 +35,26 @@ private[ml] trait LSHParams extends HasInputCol with
HasOutputCol {
/**
* Param for the dimension of LSH OR-amplification.
*
- * In this implementation, we use LSH OR-amplification to reduce the
false negative rate. The
- * higher the dimension is, the lower the false negative rate.
+ * LSH OR-amplification can be used to reduce the false negative rate.
The higher the dimension
--- End diff --
We are still using the word "dimension" here. It might also be useful to
add that reducing false negatives comes at the cost of added computation. How
does this sound?
````
* Param for the number of hash tables used in LSH OR-amplification.
*
* LSH OR-amplification can be used to reduce the false negative rate.
Higher values for this
* param lead to a reduced false negative rate, at the expense of added
computational complexity.
````
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
