Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15865#discussion_r87935645
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -109,7 +109,8 @@ public void pointTo(Object baseObject, long baseOffset,
int sizeInBytes) {
// Read the number of elements from the first 8 bytes.
final long numElements = Platform.getLong(baseObject, baseOffset);
assert numElements >= 0 : "numElements (" + numElements + ") should >=
0";
- assert numElements <= Integer.MAX_VALUE : "numElements (" +
numElements + ") should <= Integer.MAX_VALUE";
+ assert numElements <= Integer.MAX_VALUE :
+ "numElements (" + numElements + ") should <=
Integer.MAX_VALUE";
--- End diff --
Hi @ConeyLiu, it is a super minor but it seems we should make the
indentation for this (and the same instances here) double-spaced. I at least
could find some examples for this such as in `UnsafeMemoryAllocator`
```java
assert (memory.obj == null) :
"baseObject not null; are you trying to use the off-heap allocator to
free on-heap memory?";
```
or in `ShuffleSortDataFormat`
```java
assert (length <= buffer.size()) :
"the buffer is smaller than required: " + buffer.size() + " < " +
length;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
