Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15659#discussion_r88045780
  
    --- Diff: python/MANIFEST.in ---
    @@ -0,0 +1,21 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +recursive-include deps/jars *.jar
    +graft deps/bin
    +recursive-include deps/examples *.py
    +recursive-include lib *.zip
    +include README.md
    --- End diff --
    
    Actually even then it shouldn't happen "normally" (since we use 
recursive-include *.py as the inclusion rule for the python directory and our 
own graft directory is the bin directory). But still better to have the 
exclusion rule incase someone has pyc files in bin and is rolling their own 
package. Thanks for the suggestion :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to