Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15820#discussion_r88137989
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -83,6 +86,139 @@ private[kafka010] case class CachedKafkaConsumer
private(
record
}
+ /**
+ * Get the record at the `offset`. If it doesn't exist, try to get the
earliest record in
+ * `[offset, untilOffset)`.
+ */
+ def getAndIgnoreLostData(
--- End diff --
Cant these two code paths be merged?? I envision that there should be a
single method which takes a parameter "failOnDataLoss", and the method would
try to get the next fetched offset and [throw error] OR [retry with warning]
based on that flag.
I think its good simplify the code further for future maintainability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
