GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/2235

    [SPARK-3345] Do correct parameters for ShuffleFileGroup

    In the method `newFileGroup` of class `FileShuffleBlockManager`, the 
parameters for creating new `ShuffleFileGroup` object is in wrong order.
    
    Because in current codes, the parameters `shuffleId` and `fileId` are not 
used. So it doesn't cause problem now. However it should be corrected for 
readability and avoid future problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 correct_shufflefilegroup_params

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2235
    
----
commit fe7256751a90fb0ec07da5693e1ef2d9d75b33c5
Author: Liang-Chi Hsieh <[email protected]>
Date:   2014-09-02T10:24:31Z

    Do correct parameters for ShuffleFileGroup.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to