Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15894#discussion_r88207053
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -92,12 +91,27 @@ public ByteBuffer nioByteBuffer() throws IOException {
}
@Override
- public InputStream createInputStream() throws IOException {
+ public InputStream createInputStream(boolean checksum) throws
IOException {
--- End diff --
So, is this only for testing? because it's otherwise very expensive to
compute, requiring two passes over the file.
If so, should it not be in some more package-private method only and not
exposed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
