Github user chuxi commented on the pull request:
https://github.com/apache/spark/pull/2082#issuecomment-54152206
@marmbrus , do I need to check something else? Or merge the code?
Besides, I see another PR : https://github.com/apache/spark/pull/2230
:) it is my friend, I suggested him have a look of the nested parquet
sqlpaser in the sql parquet test suit which parses dot as a delimiter, not
identChar.
it has a problem that we don't know whether the dot should be in identchar
or delimiter. It leads to different sql parsing result. If only struct in a
json or parquet, apparently put the dot. in identchar is better. Does it have
some other reasons about the dot parsing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
