Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15833#discussion_r88246867
--- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala ---
@@ -221,7 +221,9 @@ object Client {
val conf = new SparkConf()
val driverArgs = new ClientArguments(args)
- conf.set("spark.rpc.askTimeout", "10")
+ if (!conf.contains("spark.rpc.askTimeout")) {
--- End diff --
OK, to move forward on this: @rxin I think this ends up affecting
application launch because this is the bit that runs applications rather than
starts workers, if that's what you mean. It will process `--conf` from the user
command line but then override it here. The report in the JIRA seems to confirm
that. At the least, this change would not affect the current behavior.
@andrewor14 that makes sense, though I note that the other `spark.rpc`
configs are not in `config/package.scala`. The `ConfigBuilder` doesn't quite
seem able to express a property whose default is another property either.
Should I still try to refactor that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
