GitHub user AnthonyTruchet opened a pull request:

    https://github.com/apache/spark/pull/15905

    [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0

    ## What changes were proposed in this pull request?
    
    CostFun used to send a dense vector of zeroes as a closure in a
    treeAggregate call. To avoid that, we replace treeAggregate by
    mapPartition + treeReduce, creating a zero vector inside the mapPartition
    block in-place.
    
    ## How was this patch tested?
    
    Tests run by hand locally. 
    (Setting up local infra to run the official Spark tests is in progress)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AnthonyTruchet/spark ENG-17719-lbfgs-only

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15905
    
----
commit e0a88bd716feae54f5ff0c235c7bb566fefcc7bd
Author: Eugene Kharitonov <e.kharito...@criteo.com>
Date:   2016-10-14T11:25:34Z

    [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0
    
    CostFun used to send a dense vector of zeroes as a closure in a
    treeAggregate call. To avoid that, we replace treeAggregate by
    mapPartition + treeReduce, creating a zero vector inside the mapPartition
    block in-place.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to