Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15915#discussion_r88426103
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -331,7 +332,8 @@ private[spark] class MemoryStore(
         var unrollMemoryUsedByThisBlock = 0L
         // Underlying buffer for unrolling the block
         val redirectableStream = new RedirectableOutputStream
    -    val bbos = new 
ChunkedByteBufferOutputStream(initialMemoryThreshold.toInt, allocator)
    +    val bbos =
    --- End diff --
    
    Rather than import a whole other class for this, you probably want to 
explicitly check and throw an exception.
    
    But, you're basically saying that this threshold can't be >= 4GB. Should 
that not just be checked earlier?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to